Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not autocorrect ActiveRecord::Migration[xxx] superclasses #52

Closed
paracycle opened this issue Feb 25, 2021 · 0 comments · Fixed by #57
Closed

Do not autocorrect ActiveRecord::Migration[xxx] superclasses #52

paracycle opened this issue Feb 25, 2021 · 0 comments · Fixed by #57
Assignees
@RyanBrushett

Comments

@paracycle
Copy link
Member

Those superclasses already have a rewriter in Sorbet that handles them explicitly, so we shouldn't be "autocorrecting" those cases in Sorbet/ForbidSuperclassConstLiteral cop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanBrushett RyanBrushett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude files in db/migrate from ForbidSuperclassConstLiteral Shopify/rubocop-sorbet
2 participants
@paracycle @RyanBrushett