Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward initialization options to addons #1204

Closed
vinistock opened this issue Nov 22, 2023 · 1 comment · Fixed by #2513
Closed

Forward initialization options to addons #1204

vinistock opened this issue Nov 22, 2023 · 1 comment · Fixed by #2513
Labels
addons Tasks related to Ruby LSP addons enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale

Comments

@vinistock
Copy link
Member

vinistock commented Nov 22, 2023 •
edited
Loading

Certain addons might need to allow users to configure functionality. For example, Steep allows you to define how many typechecking workers to fork.

We should have a generic configuration object in the extension that gets forwarded to addons based on their name. Something like

{
  "rubyLsp.addonConfigurations": {
    "nameOfAddon": { "setting": 123 }
  }
}
@vinistock vinistock added enhancement New feature or request addons Tasks related to Ruby LSP addons labels Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue is being marked as stale because there was no activity in the last 2 months

@github-actions github-actions bot added the Stale label Jan 22, 2024
@vinistock vinistock added pinned This issue or pull request is pinned and won't be marked as stale and removed Stale labels Jan 22, 2024
@vinistock vinistock mentioned this issue Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addons Tasks related to Ruby LSP addons enhancement New feature or request pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forward initialization settings to addons Shopify/ruby-lsp
1 participant
@vinistock