Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapters should be loaded automatically #226

Closed
michaelkipper opened this issue May 31, 2019 · 2 comments
Closed

Adapters should be loaded automatically #226

michaelkipper opened this issue May 31, 2019 · 2 comments
Labels

Comments

@michaelkipper
Copy link

A conversation with @rafaelfranca turned into: Why not have the "built-in" adapters load automatically?

This would be a breaking change but would reduce the barrier to verifying that Semian is being used correctly.

WDYT?

cc: @sirupsen, @csfrancis, @fw42

@fw42
Copy link
Contributor

fw42 commented Jun 3, 2019

I don't have a strong opinion, but as far as I know just loading the adapter doesn't actually enable any functionality yet (that has to be done via passing in configuration options when initializing the clients, right?).

@michaelkipper
Copy link
Author

So it seems that looking for runtime logs of type Semian is not configured for #{self.class.name}: #{semian_identifier}" would be the best course of action. Having adapters load automatically would just increase log noise, and not actually enable Semians.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants