Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering of BreadcrumbGenerators should be easier #1090

Closed
TomasLudvik opened this issue May 29, 2019 · 1 comment
Closed

Registering of BreadcrumbGenerators should be easier #1090

TomasLudvik opened this issue May 29, 2019 · 1 comment

Comments

@TomasLudvik
Copy link
Member

TomasLudvik commented May 29, 2019

What is happening

If you want to register new BreadcrumbGenerators, you need to override BreadcrumbResolverFactory.

Expected result

There should be some tag that would say, that this service is BreadcrumbGenerator and then it should be automatically registered. Same as it is in case of shopsys.friendly_url_provider.

Better way would be to tag services automatically by their classes interfaces:

  • all classes implementing FriendlyUrlDataProviderInterface should be automatically tagged by shopsys.friendly_url_provider
  • all classes implementing BreadcrumbGeneratorInterface should be automatically tagged by shopsys.breadcrumb_generator.
@boris-brtan
Copy link
Contributor

#1176 closes #919 #1090 #1111

https://help.github.com/en/articles/closing-issues-using-keywords
If the commit is in a non-default branch, the issue will remain open and the issue will be referenced with a tooltip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants