Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[project-base] deploy-to-google-cloud.sh: script sets correct elasticsearch image from dockerhub #1126

Merged
merged 4 commits into from
Jun 20, 2019

Conversation

boris-brtan
Copy link
Contributor

@boris-brtan boris-brtan commented Jun 12, 2019

Q A
Description, reason for the PR we want to use the same elasticsearch plugin for cloud deploy of project-base as in monorepo as was introduced in #1069
New feature No
BC breaks No
Fixes issues
Have you read and signed our License Agreement for contributions? Yes

@boris-brtan boris-brtan changed the title deploy-to-google-cloud.sh: script sets correct elasticsearch image from dockerhub [project-base] deploy-to-google-cloud.sh: script sets correct elasticsearch image from dockerhub Jun 12, 2019
Copy link
Contributor

@simara-svatopluk simara-svatopluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself seems good. In compare to build_kubernetes.sh missing only

  • Set domain into dev-stack
  • Wait for containers to rollout

But it seems it is intentional

docs/upgrade/UPGRADE-unreleased.md Outdated Show resolved Hide resolved
…mage from dockerhub

Co-Authored-By: Svaťa Šimara <svatopluk.simara@gmail.com>
@boris-brtan boris-brtan merged commit 242b512 into master Jun 20, 2019
@boris-brtan boris-brtan deleted the bb-google-cloud-elastic-image branch June 20, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants