[framework] CountryFormType: removal of duplicate constraint #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikBajer
reviewed
Jul 20, 2019
|
@PatrikBajer: There are in fact two inputs that you haven't fill (Czech translation and English translation) so you have to close two different messages. To make it behave differently, we would first have to define the correct behavior in detail. |
grossmannmartin
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
I agree with @PatrikBajer, two clicks are strange. But resolving this issue will need deeper thoughts about whole UX in administration and I'm ok with not resolving it right now.
LukasHeinz
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NotBlankconstraint is duplicate for the default language (defined both inmain_constraintsandentry_options.constraints).