[shopsys] releaser: fixed path for upgrading-monorepo file #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
grossmannmartin
commented
Sep 16, 2019
grossmannmartin
commented
| Q | A |
|---|---|
| Description, reason for the PR | In #1350 the upgrade notes were moved outside from the docs folder to the root as it's not the documentation. Upgrade file for monorepo was moved also, but release worker altering this file was not updated with the new file path. This PR fixes it. |
| New feature | No |
| BC breaks | No |
| Fixes issues | ... |
| Have you read and signed our License Agreement for contributions? | Yes |
grossmannmartin
changed the title
PetrHeinz
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
The fix is OK, but there are still 2 more occurrences of the wrong path in 8.0.
shopsys/upgrade/UPGRADE-v8.0.0.md
Line 58 in fc06a7a
Can you fix them as well during the merge from 7.3 to 8.0 (either now or after the v7.3.2 release)?
Created #1411 |
grossmannmartin
deleted the
mg-fix-update-upgrade-monorepo-release-worker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.