Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shopsys] Use environment variables instead of parameters.yml #1615

Closed
wants to merge 2 commits into from
Closed

[shopsys] Use environment variables instead of parameters.yml #1615

wants to merge 2 commits into from

Conversation

henzigo
Copy link
Member

@henzigo henzigo commented Jan 26, 2020

Q A
Description, reason for the PR ...
New feature Yes/No
BC breaks Yes/No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes/No

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@henzigo henzigo force-pushed the jg-env-parameters branch 10 times, most recently from 898370e to 51c3db7 Compare February 29, 2020 20:34
@sonarcloud
Copy link

sonarcloud bot commented Feb 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sslt sslt added this to the SSFW 9.1.0 milestone Jul 1, 2020
@TomasLudvik TomasLudvik added DX & Refactoring Requests for DX improvements and refactorings Enhancement New feature or request for change from user point of view Help wanted We need your help or opinion how to resolve this Infrastructure Docker, kubernetess, cloud,... labels Jul 8, 2020
@TomasLudvik TomasLudvik changed the title Use environment variables instead of parameters.yml [shopsys] Use environment variables instead of parameters.yml Jul 17, 2020
@grossmannmartin grossmannmartin mentioned this pull request Sep 15, 2020
Closed
@s3tezsky s3tezsky mentioned this pull request Oct 1, 2020
Merged
@s3tezsky
Copy link
Contributor

s3tezsky commented Oct 1, 2020

Hi @henzigo, thanks for PR. Having this would be really helpful for many developers.

I am closing this one as we are working on backward compatible alternative in #2055.

@s3tezsky s3tezsky closed this Oct 1, 2020
@s3tezsky s3tezsky deleted the jg-env-parameters branch October 3, 2020 13:01
@s3tezsky s3tezsky mentioned this pull request Oct 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DX & Refactoring Requests for DX improvements and refactorings Enhancement New feature or request for change from user point of view Help wanted We need your help or opinion how to resolve this Infrastructure Docker, kubernetess, cloud,...
Projects
None yet
Milestone
SSFW 9.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@henzigo @s3tezsky @TomasLudvik @sslt