Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shopsys] made parameters overridable by ENV variables #2055

Merged
merged 5 commits into from Oct 15, 2020

Conversation

s3tezsky
Copy link
Contributor

@s3tezsky s3tezsky commented Oct 1, 2020

Q A
Description, reason for the PR We want to be able change parameters via ENV variables to easier change setting of application in any environment. This PR allows developers to override all parameters in parameters.yaml by ENV variables. This PR also unifies usage of parameters in different environment (dev, test, prod).
New feature Yes
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

The original PR (#1615) was braking backward compatibility.

@s3tezsky s3tezsky force-pushed the ds-env-beats-parameter branch 2 times, most recently from cf4b609 to 9b94e93 Compare October 1, 2020 23:00
@s3tezsky s3tezsky added this to the SSFW 9.1.0 milestone Oct 2, 2020
@s3tezsky s3tezsky added Enhancement New feature or request for change from user point of view Infrastructure Docker, kubernetess, cloud,... labels Oct 2, 2020
@s3tezsky s3tezsky marked this pull request as ready for review October 3, 2020 11:43
Copy link
Member

@grossmannmartin grossmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the change. I like the backward compatibility kept 👍

Can you please file an issue (or solve right now, if you feel like it) to address the application environment (DEV, TEST, PROD) and debug mode set with the environment variables? It was part of #1615 and I wouldn't want to forget about it.

.ci/build_kubernetes.sh Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
docs/cookbook/dumping-and-importing-the-database.md Outdated Show resolved Hide resolved
docs/introduction/running-acceptance-tests.md Outdated Show resolved Hide resolved
project-base/build/codeception.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
project-base/composer.json Show resolved Hide resolved
project-base/.env Outdated Show resolved Hide resolved
upgrade/UPGRADE-v9.1.0-dev.md Show resolved Hide resolved
@s3tezsky
Copy link
Contributor Author

s3tezsky commented Oct 8, 2020

Can you please file an issue (or solve right now, if you feel like it) to address the application environment (DEV, TEST, PROD) and debug mode set with the environment variables? It was part of #1615 and I wouldn't want to forget about it.

At first I wanted to have it implemented here, then I thought about an effort and potantial risks so I have created an issue here #2065.

Copy link
Member

@henzigo henzigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
I just added some points from me, so please look at them.

project-base/composer.json Show resolved Hide resolved
project-base/config/parameters.yaml.dist Show resolved Hide resolved
project-base/.env Show resolved Hide resolved
project-base/.env Show resolved Hide resolved
project-base/.env.test Outdated Show resolved Hide resolved
project-base/.env.test Show resolved Hide resolved
@grossmannmartin
Copy link
Member

grossmannmartin commented Oct 13, 2020

Hey, I have one point from testing, can you please validate it?

To propagate the change of environment variables MAILER_DISABLE_DELIVERY, MAILER_DELIVERY_WHITELIST, MAILER_MASTER_EMAIL_ADDRESS I need to clean the cache

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s3tezsky s3tezsky merged commit ee7e676 into master Oct 15, 2020
@s3tezsky s3tezsky deleted the ds-env-beats-parameter branch October 15, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request for change from user point of view Infrastructure Docker, kubernetess, cloud,...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants