New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shopsys] made parameters overridable by ENV variables #2055
Conversation
cf4b609
to
9b94e93
Compare
bc1db2c
to
77f225d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the change. I like the backward compatibility kept 👍
Can you please file an issue (or solve right now, if you feel like it) to address the application environment (DEV, TEST, PROD) and debug mode set with the environment variables? It was part of #1615 and I wouldn't want to forget about it.
At first I wanted to have it implemented here, then I thought about an effort and potantial risks so I have created an issue here #2065. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
I just added some points from me, so please look at them.
7789fee
to
8d21964
Compare
Hey, I have one point from testing, can you please validate it? To propagate the change of environment variables |
9e3a5e9
to
4920485
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
parameters.yaml
by ENV variables. This PR also unifies usage of parameters in different environment (dev, test, prod).The original PR (#1615) was braking backward compatibility.