Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] unified rendering of currency and symbolAfterInput in forms #1675

Merged
merged 2 commits into from
Feb 13, 2020
Merged

[framework] unified rendering of currency and symbolAfterInput in forms #1675

merged 2 commits into from
Feb 13, 2020

Conversation

grossmannmartin
Copy link
Member

@grossmannmartin grossmannmartin commented Feb 10, 2020 •
edited
Loading

Q A
Description, reason for the PR Setting currency in MoneyFormType now renders the currency the same way as symbolAfterInput is (wrapped in span) – default appendix_blockfrom theme.html.twig is used. So it's easier to style everything after input same way.
New feature No
BC breaks Possible
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@grossmannmartin grossmannmartin merged commit 7b594fe into master Feb 13, 2020
@grossmannmartin grossmannmartin deleted the mg-unify-money-widget-rendering branch February 13, 2020 08:56
@vitek-rostislav vitek-rostislav mentioned this pull request Feb 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pesektomas pesektomas pesektomas approved these changes

@sslt sslt sslt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grossmannmartin @pesektomas @sslt