Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] prevent buying product with zero price #2239

Merged
merged 1 commit into from
Feb 16, 2021
Merged

[framework] prevent buying product with zero price #2239

merged 1 commit into from
Feb 16, 2021

Conversation

s3tezsky
Copy link
Contributor

@s3tezsky s3tezsky commented Feb 12, 2021 •
edited by sslt
Loading

Q A
Description, reason for the PR When there is no price for product and pricing group and recalculations was not executed, it was possible to buy product with zero price for a short period of time. This PR adds check which do not allow customers to buy these products. The whole bug is rare edge case, when there are incomplete data or different bug introduced during implementation.
New feature No
BC breaks No
Fixes issues closes #2205
Have you read and signed our License Agreement for contributions? Yes

@s3tezsky s3tezsky added this to the SSFW 9.1.1 milestone Feb 12, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s3tezsky s3tezsky merged commit adbcc2e into 9.1 Feb 16, 2021
@s3tezsky s3tezsky deleted the ds-zero-priced-products branch February 16, 2021 11:02
@s3tezsky s3tezsky mentioned this pull request Feb 16, 2021
Closed
@TomasLudvik TomasLudvik added the Bug Something isn't working label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@sslt sslt sslt approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
SSFW 9.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@s3tezsky @grossmannmartin @sslt @TomasLudvik