Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] admin: fix label alignment in multidomain fields #2348

Merged
merged 7 commits into from
Jun 25, 2021
Merged

[framework] admin: fix label alignment in multidomain fields #2348

merged 7 commits into from
Jun 25, 2021

Conversation

Srnka392
Copy link
Contributor

@Srnka392 Srnka392 commented Jun 7, 2021 •
edited by grossmannmartin
Loading

Q A
Description, reason for the PR Labels in the administration were bad align when the multidomain fields were added. This PR fixes this.
New feature No
BC breaks No
Fixes issues closes #1783
Have you read and signed our License Agreement for contributions? Yes

@Srnka392 Srnka392 added the Bug Something isn't working label Jun 7, 2021
@Srnka392 Srnka392 changed the base branch from master to 9.1 June 7, 2021 18:55
@Srnka392 Srnka392 force-pushed the mg-multidomain-fields-example branch from b9e326d to da65a97 Compare June 7, 2021 18:55
vitek-rostislav
vitek-rostislav approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you need to add 3.json and 4.json so it is possible to test it. Otherwise, looks ok to me, you can send it to test afterward, I do not need to see it again. But please, do not forget to remove the "DROP" commit before merging 😄

@vitek-rostislav vitek-rostislav changed the title Mg multidomain fields example [framework] admin: fix label alignment in multidomain fields Jun 8, 2021
@vitek-rostislav vitek-rostislav force-pushed the mg-multidomain-fields-example branch 3 times, most recently from 9476add to a3556e6 Compare June 8, 2021 10:34
@grossmannmartin
Copy link
Member

grossmannmartin commented Jun 10, 2021 •
edited
Loading

Hi,
I found two problems

In Safari expanded choice has some weird wrap
Snímek obrazovky 2021-06-08 v 14 34 33

Wysiwyg has domain icon over the toolbar
Snímek obrazovky 2021-06-08 v 14 36 09

@grossmannmartin grossmannmartin added this to the SSFW 9.1.2 milestone Jun 22, 2021
@grossmannmartin grossmannmartin added the Design & Appearance Issues connected to design, CSS or UX label Jun 22, 2021
@Srnka392 Srnka392 force-pushed the mg-multidomain-fields-example branch from 0c696de to 4fde358 Compare June 23, 2021 09:59
vitek-rostislav
vitek-rostislav reviewed Jun 23, 2021
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have one question, we can discuss it tomorrow if necessary 😉

packages/framework/src/Resources/views/Admin/Form/theme.html.twig Outdated Show resolved Hide resolved
@Srnka392 Srnka392 force-pushed the mg-multidomain-fields-example branch from 3da16ef to 054e258 Compare June 24, 2021 14:38
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@grossmannmartin grossmannmartin merged commit 66c0acb into 9.1 Jun 25, 2021
@grossmannmartin grossmannmartin deleted the mg-multidomain-fields-example branch June 25, 2021 07:20
@grossmannmartin grossmannmartin mentioned this pull request Jun 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

@TomasGottvald TomasGottvald TomasGottvald approved these changes

@sslt sslt sslt approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Design & Appearance Issues connected to design, CSS or UX
Projects
None yet
Milestone
SSFW 9.1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Srnka392 @grossmannmartin @vitek-rostislav @TomasGottvald @sslt @michalsrnicek