[shopsys] added test to keep elasticsearch converter and mapping in sync #2880

grossmannmartin · 2023-10-15T15:33:27Z

Q	A
Description, reason for the PR	This PR prevents forgetting to add a record to the converter when adding a new field to Elastic.
New feature	Yes
BC breaks	No
Fixes issues	...
Have you read and signed our License Agreement for contributions?	Yes

🌐 Live Preview:

UPGRADE-14.0.md

grossmannmartin force-pushed the mg-els-converter-check branch from e45adfc to 9879278 Compare October 15, 2023 15:35

TomasLudvik requested changes Oct 16, 2023

View reviewed changes

UPGRADE-14.0.md Outdated Show resolved Hide resolved

TomasLudvik approved these changes Oct 16, 2023

View reviewed changes

pk16011990 approved these changes Oct 17, 2023

View reviewed changes

grossmannmartin added 5 commits October 18, 2023 17:40

parameters are now autofilled in product elasticsearch converter

3dc74b1

added missing fields to elasticsearch converter

f7cc104

added missing fields to elasticsearch mapping files

f2161d7

added test to keep elasticsearch converter and mapping in sync

221a603

added upgrade notes

3355efa

grossmannmartin force-pushed the mg-els-converter-check branch from f2448bb to 3355efa Compare October 18, 2023 15:41

grossmannmartin enabled auto-merge October 18, 2023 15:42

grossmannmartin added the DX & Refactoring Requests for DX improvements and refactorings label Oct 18, 2023

grossmannmartin merged commit 9bafdb0 into 14.0 Oct 18, 2023
17 checks passed

grossmannmartin deleted the mg-els-converter-check branch October 18, 2023 16:02

grossmannmartin mentioned this pull request Feb 7, 2024

[project-base] add missing "accessories" to Elasticsearch index definition #2305

Closed

Provide feedback