[shopsys] Updated PHP to version 7.3

[grossmannmartin]

Q	A
Description, reason for the PR	Support new version of PHP
New feature	No
BC breaks	No
Fixes issues	...
Standards and tests pass	Yes
Have you read and signed our License Agreement for contributions?	Yes

[grossmannmartin]

Currently, we have to install composer dependencies with --ignore-platform-reqs, because FriendsOfPHP/PHP-CS-Fixer does not support PHP 7.3.
There is an issue about this topic.

[vitek-rostislav]

Currently, we have to install composer dependencies with --ignore-platform-reqs, because FriendsOfPHP/PHP-CS-Fixer does not support PHP 7.3.
There is an issue about this topic.

@TomasVotruba, what do you think about this, please?

It seems a little bit dangerous to me - when we want to say that we support php 7.3, we should not use tools that lack the support. And by ignoring the platform requirements, we could overlook some incompatibility problems, right?

Btw, should not the dependency on symplify/easy-coding-standard be defined in require-dev?

[TomasVotruba]

It's has nothing to do with code. php-cs-fixer runs on PHP 7.3 with no problem.
It's missuse of composer to force people to work, see https://stackoverflow.com/a/53727287/1348344

Btw, should not the dependency on symplify/easy-coding-standard be defined in require-dev?

What line do you talk about? Why?

[boris-brtan]

Hi, thx for the PR, i left just some suggestions.
I tested this on frontend and in administration and it seems to be working well from the users point of view.
There is also one in rv message above.

[vitek-rostislav]

Hi @TomasVotruba, thanx for your reply 👍

btw, should not the dependency on symplify/easy-coding-standard be defined in require-dev?

What line do you talk about? Why?

My bad...I was thinking about shopsys/coding-standards which is in require-dev indeed. The symplify/easy-coding-standard is defined in require section in monorepo only so everything is ok 🙂

[grossmannmartin]

I simplified this PR, so it covers only one thing - Upgrade to PHP 7.3.
We decided, that we don't want to install dependencies with --ignore-platform-reqs option, so I'm putting this on hold until PHP-CS-Fixer/PHP-CS-Fixer#3697 (PR PHP-CS-Fixer/PHP-CS-Fixer#4184) will be solved.

Memory limit of PhpStan or possible upgrade of it should be solved in an independent PR, thank you for your insights on this topic 👍

[keradus]

FYI @grossmannmartin : PHP CS Fixer v2.14 supports PHP 7.3

[MattCzerner]

Seems like its done bois. PHP-CS-Fixer/PHP-CS-Fixer#3697 (comment)