[framework] data object properties review #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simara-svatopluk
commented
Feb 4, 2019
simara-svatopluk
commented
| Q | A |
|---|---|
| Description, reason for the PR | review of data object properties and documentation of usage |
| New feature | No |
| BC breaks | No |
| Fixes issues | ... |
| Standards and tests pass | Yes |
| Have you read and signed our License Agreement for contributions? | Yes |
simara-svatopluk
force-pushed
the
ss-data-objects-review
branch
7 times, most recently
from
d46dc5b
to
58b9bbe
Compare
boris-brtan
suggested changes
Feb 6, 2019
simara-svatopluk
force-pushed
the
ss-data-objects-review
branch
4 times, most recently
from
462301c
to
ff9190e
Compare
boris-brtan
approved these changes
Feb 7, 2019
simara-svatopluk
force-pushed
the
ss-data-objects-review
branch
3 times, most recently
from
7412b0e
to
aa477f2
Compare
added 14 commits
February 12, 2019 12:27
… be always bool - it is the way we use bool properties in data objects - also the property is used everywhere as it is bool (not nullable)
- $name is localized, so it is an array of strings - $sellingDenied is always boolean
…erywhere used as string
…t value false becuase the code expects this variable to be bool
- now sets also $domainId because it is expected by the method name
…alue "1" - because the value was already rewritten in all usages and now domainId properties are unified in all *Data objects
- it is the way we use bool properties in data objects - also the property is used everywhere as it is bool (not nullable)
- it is the way we use bool properties in data objects - also the property is used everywhere as it is bool (not nullable)
… used by the system
added 2 commits
February 12, 2019 12:27
- for all locales - initializes with null (as the current admin form does) - changed phpdoc of multilanguage properties appropriately - fixed code snippets in documentation
…ey are initialized for each locale
simara-svatopluk
force-pushed
the
ss-data-objects-review
branch
from
3547ae9
to
ed0c101
Compare
PetrHeinz
reviewed
Feb 12, 2019
|
|
simara-svatopluk
force-pushed
the
ss-data-objects-review
branch
from
febd126
to
95993b1
Compare
added 2 commits
February 13, 2019 07:53
…llLocales(), to avoid code duplication - changed return value of Domain:getAllLocales() to keyed array so it matches Localization method perfectly
simara-svatopluk
force-pushed
the
ss-data-objects-review
branch
from
2fe450f
to
06d2760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.