Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] data object properties review #787

Merged
merged 21 commits into from Feb 13, 2019
Merged

[framework] data object properties review #787

merged 21 commits into from Feb 13, 2019

Commits on Feb 12, 2019

  1. fixed OrderData bool property $deliveryAddressSameAsBillingAddress to… 

    … be always bool

- it is the way we use bool properties in data objects
- also the property is used everywhere as it is bool (not nullable)
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    61290a3 View commit details
    Browse the repository at this point in the history

  2. fixed CategoryData property $descriptions typehint as it be nullable

    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    a02db2c View commit details
    Browse the repository at this point in the history

  3. fixed ProductData phpdocs 

    - $name is localized, so it is an array of strings
- $sellingDenied is always boolean
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    5293598 View commit details
    Browse the repository at this point in the history

  4. documented ProductData $outOfStockAction property - it is a Product c… 

    …onstant
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    fbf468c View commit details
    Browse the repository at this point in the history

  5. fixed ProductData $flags property typehint

    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    f7fef71 View commit details
    Browse the repository at this point in the history

  6. changed type of Currency::DEFAULT_EXCHANGE_RATE to string as it is ev… 

    …erywhere used as string
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    e38455f View commit details
    Browse the repository at this point in the history

  7. fixed MailTemplateData $deleteAttachment property to bool with defaul… 

    …t value false becuase the code expects this variable to be bool
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    3e04f81 View commit details
    Browse the repository at this point in the history

  8. fixed MessageData $variablesReplacementsForSubject property typehint

    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    b475bc4 View commit details
    Browse the repository at this point in the history

  9. refactored responsibility of UserDataFactory::createForDomainId 

    - now sets also $domainId because it is expected by the method name
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    c7d657c View commit details
    Browse the repository at this point in the history

  10. changed UserData property $domainId to int|null and removed default v… 

    …alue "1"

- because the value was already rewritten in all usages and now domainId properties are unified in all *Data objects
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    06c1fe7 View commit details
    Browse the repository at this point in the history

  11. fixed FrontOrderData bool properties to be always bool 

    - it is the way we use bool properties in data objects
- also the property is used everywhere as it is bool (not nullable)
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    bbdf595 View commit details
    Browse the repository at this point in the history

  12. fixed ProductFilterData bool property $inStock to be always bool 

    - it is the way we use bool properties in data objects
- also the property is used everywhere as it is bool (not nullable)
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    2638df3 View commit details
    Browse the repository at this point in the history

  13. documented recommendations for *Data object fields

    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    b7c80c7 View commit details
    Browse the repository at this point in the history

  14. added method Domain:getAllLocales() that returns all locales that are… 

    … used by the system
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    50d967f View commit details
    Browse the repository at this point in the history

  15. added initialization of Data multilanguage properties 

    - for all locales
- initializes with null (as the current admin form does)
- changed phpdoc of multilanguage properties appropriately
- fixed code snippets in documentation
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    76f646a View commit details
    Browse the repository at this point in the history

  16. documented recommendations for multilanguage data attributes after th… 

    …ey are initialized for each locale
    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    ed0c101 View commit details
    Browse the repository at this point in the history

  17. added upgrade instructions for multilanguage data factories

    Svaťa Šimara committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    64a1865 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. explained creation of multidomain and multilanguage data a bit better

    @PetrHeinz
    PetrHeinz authored and Svaťa Šimara committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    11c44da View commit details
    Browse the repository at this point in the history

  2. refactored Localization::getLocalesOfAllDomains() to use Domain::getA… 

    …llLocales(), to avoid code duplication

- changed return value of Domain:getAllLocales() to keyed array so it matches Localization method perfectly
    Svaťa Šimara committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    60c1f77 View commit details
    Browse the repository at this point in the history

  3. reworded "phpdoc" to correct "PHPDoc annotation"

    Svaťa Šimara committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    06d2760 View commit details
    Browse the repository at this point in the history

  4. reviewed data object properties (#787)

    Svaťa Šimara committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    04155aa View commit details
    Browse the repository at this point in the history