Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[framework] fixed files uploading #869

Merged
merged 2 commits into from
Feb 26, 2019
Merged

[framework] fixed files uploading #869

merged 2 commits into from
Feb 26, 2019

Conversation

vitek-rostislav
Copy link
Contributor

Q A
Description, reason for the PR weird behavior of file uploads (see #863), also renaming from jpeg to jpg was not working
New feature Yes
BC breaks Yes
Fixes issues closes #863
Standards and tests pass Yes
Have you read and signed our License Agreement for contributions? Yes

@vitek-rostislav vitek-rostislav force-pushed the rv-uploaded-files branch 2 times, most recently from 682535e to a9a2666 Compare February 25, 2019 09:52
grossmannmartin
grossmannmartin requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@grossmannmartin grossmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, nice work.
Just a little note about upgrade notes.

docs/upgrade/UPGRADE-unreleased.md Outdated Show resolved Hide resolved
packages/framework/src/Component/Image/Processing/ImageProcessor.php Show resolved Hide resolved
grossmannmartin
grossmannmartin requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@grossmannmartin grossmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While testing I've noticed that ImageFactory::create has outdated phpdoc annotation of $temporaryFilename (null is no longer an acceptable value).

But the problem disappeared 👍 so tests passed.

@vitek-rostislav
Copy link
Contributor Author

Thanks, the annotation fixed 👍

@vitek-rostislav
ImageFactoryInterface::create(): temporaryFilename parameter is not n…
568a5e6 
…ullable
@vitek-rostislav
ImageProcessor::convertToShopFormatAndGetNewFilename() must work with
7250af4 
files in local filesystem only

- image is moved into main abstract filesystem after an entity is
flushed (in FileUpload::postFlushEntity())
@vitek-rostislav vitek-rostislav merged commit ff88d56 into master Feb 26, 2019
@vitek-rostislav vitek-rostislav deleted the rv-uploaded-files branch February 26, 2019 08:29
@grossmannmartin grossmannmartin mentioned this pull request Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grossmannmartin grossmannmartin grossmannmartin approved these changes

@VitMickal VitMickal VitMickal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vitek-rostislav @grossmannmartin @VitMickal