Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added optional argument for profile name #1391

Closed

Conversation

wrongspot
Copy link

1. Why is this change necessary?

Cronjobs can not handle interactive choice for profile name.

2. What does this change do, exactly?

With this change you can provide an optional profile name on bin/console import:entity command. The interactive profile choice will skip and make Cronjobs happy.

3. Describe each step to reproduce the issue or behaviour.

Cronjobs can not handle interactive choices.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2020

CLA assistant check
All committers have signed the CLA.

@wrongspot wrongspot force-pushed the import-export-optional-profile branch 3 times, most recently from 1c3990a to 32214b9 Compare October 1, 2020 23:03
@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-11231

Please use this issue to track the state of your pull request.

@shopwareBot shopwareBot added QuickPick hacktoberfest-accepted PR is accepted by us for Hacktoberfest labels Oct 23, 2020
@philipreinken philipreinken assigned J-Rahe and unassigned raknison Nov 30, 2020
@J-Rahe
Copy link
Contributor

J-Rahe commented Dec 3, 2020

Hey @wrongspot, your PR was merged, thanks for your contribution : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted hacktoberfest-accepted PR is accepted by us for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants