-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT-14586 Resolve Symfony 5.1 deprecations #1759
Conversation
Not entirely sure why the EDIT: Nevermind, I just checked PRs from other contributors as well and it seems like that one test is failing for everyone. This change is ready for review :)! |
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TheKeymaster , thank you for putting in the time to create this pull request 🙂 I've only noticed this after the import unfortunately - would you mind adjusting the changelog entry?
changelog/_unreleased/2021-04-01-resolve-symfony-5-1-deprecations.md
Outdated
Show resolved
Hide resolved
8a7631e
to
a4755e2
Compare
Hi @philipgatzka, I have resolved your comments, please have another look. |
Thank you for your contribution @TheKeymaster ! 🥳 |
1. Why is this change necessary?
Since Symfony 5.1 not setting the
framework.router.utf8
option is considered deprecated. See:Without these change my plugin tests fail, as the Symfony Deprecation Helper gets mad at me :(.
2. What does this change do, exactly?
Set the
utf8
option to betrue
.3. Describe each step to reproduce the issue or behaviour.
Run tests that interact with the Symfony/Shopware router.
4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/NEXT-14586
5. Checklist
I have written tests and verified that they fail without my change=> => Not applicableI have written or adjusted the documentation according to my changes=> Not applicableThis change has comments for package types, values, functions, and non-obvious lines of code=> Not applicable