Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-14586 Resolve Symfony 5.1 deprecations #1759

Closed

Conversation

TheKeymaster
Copy link

1. Why is this change necessary?

Since Symfony 5.1 not setting the framework.router.utf8 option is considered deprecated. See:

Without these change my plugin tests fail, as the Symfony Deprecation Helper gets mad at me :(.

image

2. What does this change do, exactly?

Set the utf8 option to be true.

3. Describe each step to reproduce the issue or behaviour.

Run tests that interact with the Symfony/Shopware router.

4. Please link to the relevant issues (if any).

https://issues.shopware.com/issues/NEXT-14586

5. Checklist

  • I have written tests and verified that they fail without my change => => Not applicable
  • I have squashed any insignificant commits
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes => Not applicable
  • This change has comments for package types, values, functions, and non-obvious lines of code => Not applicable
  • I have read the contribution requirements and fulfil them.

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2021

CLA assistant check
All committers have signed the CLA.

@TheKeymaster
Copy link
Author

TheKeymaster commented Apr 1, 2021

Not entirely sure why the Cypress step fails, but I can not re-run it either. Could someone from you at Shopware do that for me? I do not think that it is related to my change, but with a re-run we would be certain. Thank you guys!

EDIT: Nevermind, I just checked PRs from other contributors as well and it seems like that one test is failing for everyone.

This change is ready for review :)!

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-14633

Please use this issue to track the state of your pull request.

Copy link
Contributor

@philipreinken philipreinken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TheKeymaster , thank you for putting in the time to create this pull request 🙂 I've only noticed this after the import unfortunately - would you mind adjusting the changelog entry?

@TheKeymaster
Copy link
Author

Hi @philipgatzka, I have resolved your comments, please have another look.

@philipreinken
Copy link
Contributor

Thank you for your contribution @TheKeymaster ! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants