Add customer changed email event #2826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trandangtri
reviewed
Nov 7, 2022
Comment on lines
+136
to
+140
|
|
||
| $data->set('password', null); | ||
|
|
||
| $event = new CustomerChangedEmailEvent($context, $customer, $data); | ||
| $this->eventDispatcher->dispatch($event); |
There was a problem hiding this comment.
Hi @MelvinAchterhuis, do you think it will dispatch a single event twice?
trandangtri
reviewed
Nov 7, 2022
| $requestDataBag->set('password', null); | ||
|
|
||
| $event = new CustomerChangedEmailEvent($context, $customer, $requestDataBag); | ||
| $this->eventDispatcher->dispatch($event); |
There was a problem hiding this comment.
Hi @MelvinAchterhuis
Would you please adjust the testcases as well, to ensure this event will be fired.
|
We will close this for now because of inactivity, if you come around working on the open comments feel free to reopen the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
When connecting with external data systems it can be handy to know when a customer changes their email address in Shopware. This also sets the foundation for a new email template that can be send to the old email address to inform the customer that their email address is changed + what the new email address is
2. What does this change do, exactly?
Adds a new event that dispatches when customer changes their email address in Shopware
3. Describe each step to reproduce the issue or behaviour.
N/A
4. Please link to the relevant issues (if any).
N/A
5. Checklist