Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopware is only PHP 8.1 compatible starting from v6.4.6.0 #2881

Closed
alessandroaussems opened this issue Dec 9, 2022 · 3 comments
Closed
Labels

Comments

@alessandroaussems
Copy link
Contributor

PHP Version

8.1

Shopware Version

6.4.4.1

Expected behaviour

According to the composer.json file Shopware 6.4.4.1 should be PHP 8.1 compatible. But it's not...
Because the necessary changes (d8214c7) are only available in v6.4.6.0

Actual behaviour

6.4.4.1 should be PHP 8.1 compatible according to composer.json

How to reproduce

Try to run Shopware 6.4.4.1 on PHP 8.1. You 'll seen encounter errors:
Shopware\Core\Framework\DataAbstractionLayer\EntityDefinition::decode(): Argument #2 ($value) must be of type ?string, int given

This is because the necessary change:
'driverOptions' => [ \PDO::ATTR_STRINGIFY_FETCHES => true, ],

is not available in 6.4.4.1

@shyim
Copy link
Member

shyim commented Dec 9, 2022

We don't release patch updates for older versions. Update to a newer version

@shyim shyim closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2022
@alessandroaussems
Copy link
Contributor Author

@shyim That's not the point. I know you won't patch older versions. But I think SW should be more careful with these kind of things. If composer.json states that a certain release is compatible with a certain php version, it should also be compatible. You can't just mess around with this stuff... How can we otherwise trust the composer.json dependencies and requirements in the future...

@keulinho
Copy link
Contributor

Thanks for the input, we have now limited the upper bound for the supported php versions, starting with v6.5.0.0.

See 12dcffb for reference.

shopwareBot pushed a commit to shopware/administration that referenced this issue Dec 20, 2022
shopwareBot pushed a commit to shopware/storefront that referenced this issue Dec 20, 2022
shopwareBot pushed a commit to shopware/elasticsearch that referenced this issue Dec 20, 2022
pweyck pushed a commit to shopwareArchive/recovery that referenced this issue May 5, 2023
pweyck pushed a commit to shopware/elasticsearch that referenced this issue Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants