NEXT-00000 - Fix profiler table & icons #3653
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
Some of the custom icons in the Symfony Profiler toolbar are colored, others are not. To use a consistent style for these toolbar icons, I changed them to look like the original Symfony icons using
fill=currentcolor
– I fixed the feature flag icon by removing the area around it. Due to the old span, the icon were no longer aligned correctly
In one of the last Symfony Profiler versions it was changed so that
Sfjs
variable is no longer available in the overview. Shopware previously used this to update the database table. I've now changed it to update the elements without the externalSfjs
variable by simply adjusting the javascript a bitCurrently you can now longer sort the database table or click the
Explain query
button correctly. This PR fixes both of this issues2. What does this change do, exactly?
flags.html.twig
file to correctly display the icon in the toolbardb.html.twig
to correctly work without the symfony toolbar javascript3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist