Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-00000 - Fix profiler table & icons #3653

Closed
wants to merge 1 commit into from

Conversation

akf-bw
Copy link
Contributor

@akf-bw akf-bw commented Apr 9, 2024

1. Why is this change necessary?

  • Some of the custom icons in the Symfony Profiler toolbar are colored, others are not. To use a consistent style for these toolbar icons, I changed them to look like the original Symfony icons using fill=currentcolor
    – I fixed the feature flag icon by removing the area around it. Due to the old span, the icon were no longer aligned correctly

  • In one of the last Symfony Profiler versions it was changed so that Sfjs variable is no longer available in the overview. Shopware previously used this to update the database table. I've now changed it to update the elements without the external Sfjs variable by simply adjusting the javascript a bit

  • Currently you can now longer sort the database table or click the Explain query button correctly. This PR fixes both of this issues

2. What does this change do, exactly?

  • Changed the feature flag icon in the profiler toolbar to receive the correct color styling
  • Changed the database icon in the profiler toolbar to receive the correct color styling
  • Changed the flags.html.twig file to correctly display the icon in the toolbar
  • Changed the db.html.twig to correctly work without the symfony toolbar javascript
  • Changed the elasticsearch icon in the profiler toolbar to receive the correct color styling

3. Describe each step to reproduce the issue or behaviour.

  • Open the symfony profiler / toolbar

4. Please link to the relevant issues (if any).

  • /

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@shyim
Copy link
Member

shyim commented Apr 9, 2024

src/Core/Profiling/Resources/views/Collector/icon.svg seems broken. GitHub cannot show a preview

@shyim shyim self-assigned this Apr 9, 2024
@akf-bw
Copy link
Contributor Author

akf-bw commented Apr 9, 2024

@shyim

src/Core/Profiling/Resources/views/Collector/icon.svg seems broken. GitHub cannot show a preview

Yes because the old svg icon was invalid. I also fixed this with my changes:
image

@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-34922

Please use this issue to track the state of your pull request.

@akf-bw akf-bw deleted the fix-profiler-table-and-icons branch April 9, 2024 09:11
@shyim shyim added Accepted and removed Scheduled labels Apr 9, 2024
@shyim
Copy link
Member

shyim commented Apr 9, 2024

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants