Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix engine/updater to pass the APK path rather than parsing from libapp.so path #62

Open
eseidel opened this issue Apr 12, 2023 · 1 comment

Comments

@eseidel
Copy link
Contributor

eseidel commented Apr 12, 2023

My current hacky code in updater.rs parses the last provided libapp.so path, assuming it's a full path to the (possibly extracted) libapp.so and then finding the base.apk relative to that path. We could do something more robust, like passing the base.apk path from the engine to the rust.

@eseidel
Copy link
Contributor Author

eseidel commented May 12, 2023

This is a decent first issue if someone is wanting to learn how to compile and change our engine code.

The code which would need to change here is:
https://github.com/shorebirdtech/engine/blob/flutter_release/3.10.0/shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java#L216
And here:
https://github.com/shorebirdtech/engine/blob/flutter_release/3.10.0/shell/platform/android/flutter_main.cc#L210

@eseidel eseidel transferred this issue from shorebirdtech/shorebird Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant