Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement less than/greater than/between operators on attributes #49

Closed
Shpigford opened this issue Feb 4, 2020 · 1 comment
Closed

Implement less than/greater than/between operators on attributes #49

Shpigford opened this issue Feb 4, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Shpigford
Copy link
Owner

Certain attributes are ultimately numeric (at least with how they're stored) and as such we can use lt/gt/between operators on them.

  • Key
  • Danceability
  • Acoustic Likeliness
  • Energy

Changing them in the rule builder is straight forward. The bigger change will be in the Playlist model for the actual SQL queries.
@Shpigford Shpigford added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 4, 2020
Shpigford added a commit that referenced this issue Feb 4, 2020
@Shpigford
lt/gt/between on Key
279925a 
#49
Shpigford added a commit that referenced this issue Feb 4, 2020
@Shpigford
lt/gt/between on acousticness
20ba356 
#49
Shpigford added a commit that referenced this issue Feb 4, 2020
@Shpigford
lt/gt/between on energy
ac27bca 
#49
@Shpigford
Copy link
Owner Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shpigford