Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SAN certs (multiple domains) #9

Closed
axelfontaine opened this issue Feb 20, 2016 · 5 comments
Closed

Add support for SAN certs (multiple domains) #9

axelfontaine opened this issue Feb 20, 2016 · 5 comments

Comments

@axelfontaine
Copy link

No description provided.

@shred
Copy link
Owner

shred commented Feb 20, 2016

Actually, it is already added and works fine for me. Each domain needs to be authorized individually. After that, create a CSR with SAN of all domains. You can use the CSRBuilder (in the acme4j-utils module) for that:

CSRBuilder csrb = new CSRBuilder();
csrb.addDomain("example.org");
csrb.addDomain("www.example.org");
// you can add even more domains...
csrb.sign(domainKeyPair);
URI certUri = client.requestCertificate(account, csrb.getEncoded());

I have successfully retrieved SAN certs that way.

@axelfontaine
Copy link
Author

Awesome! Thank you! You could probably even just copy paste this and add it to the docs :-)

Great work BTW! Small single-purpose library. Solves one problem and solves it well. Almost no dependencies and great documentation. This is how things should be 👍

@shred
Copy link
Owner

shred commented Feb 20, 2016

The example was copied from the docs... ;-) But indeed, I could explain a little more how to get SAN certs.

@axelfontaine
Copy link
Author

I had actually read that page and somehow missed it. Sorry about the trouble and thanks again!

@shred
Copy link
Owner

shred commented Feb 20, 2016

No trouble at all! Thank you for your positive feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants