Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X 10.10 build issues #37

Closed
dognotdog opened this issue Jan 29, 2017 · 1 comment
Closed

OS X 10.10 build issues #37

dognotdog opened this issue Jan 29, 2017 · 1 comment

Comments

@dognotdog
Copy link

dognotdog commented Jan 29, 2017

Getting errors below when compiling current master, after changing the Darwin build params to (because target issues up to at least OSX version 10.7):

COMMON_CXXFLAGS= -arch x86_64 -mmacosx-version-min=10.10 -std=gnu++11 -stdlib=libc++
COMMON_LDFLAGS= -arch x86_64 -mmacosx-version-min=10.10

The errors:

src/Command.cpp:719:23: error: comparison between pointer and integer ('char *' and 'int')
            if (input == '\0' ||
                ~~~~~ ^  ~~~~
src/Command.cpp:822:23: error: comparison between pointer and integer ('char *' and 'int')
            if (input == '\0' ||

Looks like a genuine bug where the pointer is compared to 0 instead of the data the pointer points to (as the pointer is rejected when NULL a line earlier anyway) changing to *input == ... apparently fixes things and it compiles and works

@shumatech
Copy link
Owner

Thanks for reporting! This is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants