Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termios is unix only #1

Closed
sowdust opened this issue Apr 17, 2020 · 3 comments
Closed

termios is unix only #1

sowdust opened this issue Apr 17, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@sowdust
Copy link

sowdust commented Apr 17, 2020

It doesn't work on windows since it's missing termios library
@ShutdownRepo
Copy link
Owner

Thanks for this issue! Does this concern the simple_term_menu library or something else?

@ShutdownRepo ShutdownRepo added the bug Something isn't working label Apr 17, 2020
@ShutdownRepo
Copy link
Owner

Okay got it. The simple_term_menu relies on termios that only works on Unix systems.
I'm working on a fix but the menu appearance won't be the same.

ShutdownRepo pushed a commit that referenced this issue Apr 17, 2020
Fix for issue #1
2e28b35 
This is a fix for issue #1. The menu is created with `simple_term_menu`, 
a lib that relies on `termios` that only works on Unix systems. This fix 
checks wether the OS is Windows or not. For Windows, the menu is based 
on the `console-menu` lib.
@ShutdownRepo
Copy link
Owner

Fixed in 2e28b35

ShutdownRepo pushed a commit that referenced this issue Apr 20, 2020
Additionnal fix for #1
d564d69
@ShutdownRepo ShutdownRepo mentioned this issue Apr 20, 2020
Merged
@t0-git t0-git mentioned this issue Jul 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sowdust @ShutdownRepo