Fix(common): format logs in correct local timezone #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs were formatted in UTC regardless of local timezone, resulting in incorrect times. We now format the datetime with rfc3339 which includes the correct timezone.
timonv
changed the title
|
Thanks for the feedback, added a clarifying comment, cleaned up and readded dim() |
Correct time & timezone |
oddgrd
approved these changes
Jun 23, 2023
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
* Fix logs formatted in wrong timezone Logs were formatted in UTC regardless of local timezone, resulting in incorrect times. We now format the datetime with rfc3339 which includes the correct timezone. * Remove mutex * Reset Cargo.toml to main * Add back datetime dim() formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Logs were formatted in UTC regardless of local timezone, resulting in incorrect times. We now format the datetime with rfc3339 which includes the correct timezone.
Testing is a bit hacky with the mutex, as per the comment, Time uses libc to get the timezone. By forcing the env var to the expected timezone we get the result we want. Originally had more than one test, hence the mutex. Decided to leave it in, as any additional test using timezones would yield crazy racing errors. Happy to remove it if needed.
Closes #834
How has this been tested? (if applicable)
Added unit tests.
Having some issues running the full test suite / local env. Should be alright but timezones.