resource-recorder: update the docker compose file #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
changed the title
chesedo
reviewed
Jul 18, 2023
iulianbarbu
force-pushed
the
feature/eng-735-update-the-docker-compose-files-for-resource-recorder
branch
from
c7ddd5a
to
ade7e07
Compare
iulianbarbu
force-pushed
the
feature/eng-735-update-the-docker-compose-files-for-resource-recorder
branch
from
ade7e07
to
b348a09
Compare
...of the custom directory from the examples to custom-serivce. This made our init for `None` example fail.
iulianbarbu
force-pushed
the
feature/eng-735-update-the-docker-compose-files-for-resource-recorder
branch
from
8a33c78
to
e4bf12f
Compare
chesedo
reviewed
Jul 20, 2023
chesedo
approved these changes
Jul 20, 2023
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jul 21, 2023
* resource-recorder: added docker compose service * resource-recorder: added prepare.sh * docker-compose: fix provisioner/resource-recorder deps * docker-compose: fixed resource-recorder args * review/resource-recorder: addressed P review and fixed db_path * cargo-shuttle: custom resources changed the name... ...of the custom directory from the examples to custom-serivce. This made our init for `None` example fail.
jonaro00
deleted the
feature/eng-735-update-the-docker-compose-files-for-resource-recorder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a docker-compose service for resource-recorder and
Makefiletag env variable.How has this been tested? (if applicable)
Started Shuttle locally and it worked. Tested on unstable too.