Change service id from UUIDv4 to ULID #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
force-pushed
the
feature/eng-707-update-the-service_id-in-deployer-to-a-ulid
branch
from
befac32
to
7e82443
Compare
iulianbarbu
force-pushed
the
feature/eng-707-update-the-service_id-in-deployer-to-a-ulid
branch
2 times, most recently
from
96faad6
to
c00896e
Compare
iulianbarbu
added
the
B-M
iulianbarbu
force-pushed
the
feature/eng-707-update-the-service_id-in-deployer-to-a-ulid
branch
from
752a6fd
to
7b5dc05
Compare
iulianbarbu
force-pushed
the
feature/eng-707-update-the-service_id-in-deployer-to-a-ulid
branch
from
441fd00
to
2f56ec3
Compare
We use uuid v4 which doesn't contain timestamp information. This means converting them to ulid will make for irelevant time information within the ulids. To have though some useful time info (that can be accounted for created_at time information) inside the service_ids, we create ulids based on 2023-06-01 datetime (referring to before beta release) that will help us identify these services, while the new services will use ulid to convey information about creation timestamp. (use "git push" to publish your local commits)
iulianbarbu
force-pushed
the
feature/eng-707-update-the-service_id-in-deployer-to-a-ulid
branch
from
2f56ec3
to
830aaf3
Compare
|
Closing this in favour of #1101. |
jonaro00
deleted the
feature/eng-707-update-the-service_id-in-deployer-to-a-ulid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changed service_id from
UUIDtoULID.Added deployer db migration as well, based on shuttle-hq/sqlite-ulid#1.
This is based on: #1092.
How has this been tested? (if applicable)
Deployed it on unstable and tested it.