Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime): replace trace with println #1190

Merged
merged 2 commits into from Aug 30, 2023
Merged

refactor(runtime): replace trace with println #1190

merged 2 commits into from Aug 30, 2023

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Aug 30, 2023

Fixes the following build failure:

error[E0432]: unresolved import `tracing`
  --> runtime/src/next/mod.rs:26:5
   |
26 | use tracing::{error, trace, warn};
   |     ^^^^^^^ help: a similar path exists: `shuttle_common::tracing`

chesedo
chesedo reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use println instead

runtime/Cargo.toml Outdated Show resolved Hide resolved
@orhun orhun force-pushed the fix/add_missing_tracing_dep branch from bf2ece4 to 8647dd3 Compare August 30, 2023 08:57
@orhun orhun changed the title fix(runtime): add missing tracing dependency refactor(runtime): replace trace with println Aug 30, 2023
chesedo
chesedo approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

runtime/src/next/mod.rs Outdated Show resolved Hide resolved
@chesedo chesedo merged commit 786c2dd into shuttle-hq:feat/shuttle-logger-service Aug 30, 2023
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orhun @chesedo