feat(codegen): restore default log level, improve error messages #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Sep 8, 2023
deployer/src/deployment/run.rs
Outdated
| @@ -375,12 +377,12 @@ async fn load( | |||
| if response.success { | |||
| Ok(()) | |||
| } else { | |||
| error!(error = %response.message, "failed to load service"); | |||
| error!(error = %response.message, "Failed to load service"); | |||
There was a problem hiding this comment.
Nit: IMO we should be consistent with the casing of error messages (and potentially other traces too, but at least error messages), and lowercase is the norm (e.g. rust std uses lowercase without trailing punctuation). We could also discuss this internally and agree on a standard.
orhun
approved these changes
Sep 8, 2023
…huttle into feature/eng-1213-tracing-default-log-level
jonaro00
merged commit e8e0f12
into
shuttle-hq:feat/shuttle-logger-service
17 of 34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How has this been tested? (if applicable)