Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: builder service #1244

Merged
merged 2 commits into from Sep 18, 2023
Merged

feat: builder service #1244

merged 2 commits into from Sep 18, 2023

Conversation

chesedo
Copy link
Member

@chesedo chesedo commented Sep 15, 2023

Description of change

Extracts the builder service from the scaling feature branch

How has this been tested? (if applicable)

Not at all since it is not hooked up to deployer yet

* feat: builder init

* feat: build route

* feat: builder service

* feat: binary and docker image

* refactor: clippy suggestions

* refactor: move test helpers to common crate

* refactor: trim deployer-alpha

* refactor: get name from nbuild

* refactor: .crate to .tar.gz

* refactor: Cmd to Entrypoint
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, barring the discussed CI/Docker/Makefile changes, is the plan to do that in a separate PR?

I also suppose we can't add the deploy layer yet, since that would cause the user to see duplicated build logs.

@oddgrd oddgrd merged commit 361e00e into main Sep 18, 2023
33 checks passed
@oddgrd oddgrd deleted the feat/builder branch September 18, 2023 11:50
iulianbarbu pushed a commit to GugaGongadze/shuttle that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants