feat(cargo-shuttle): add suggestions in case of cmd failures #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good question. Not very sure how to do it easier than simulating the error by interfering with the code, when running |
orhun
approved these changes
Sep 15, 2023
iulianbarbu
force-pushed
the
feature/eng-1283-assess-whether-we-can-suggest-project-restart-anywhere
branch
from
a9122bf
to
3025bcc
Compare
iulianbarbu
added a commit
to GugaGongadze/shuttle
that referenced
this pull request
Sep 27, 2023
…-hq#1245) * feat(cargo-shuttle): add suggestions in case of cmd failures * refactor(cargo-shuttle): break suggestions module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added suggestions in case of requests' errors when running
cargo-shuttlecommands. These suggestions do not consider the requests' status codes. This is a short-term solution for handling errors across CLI user flows (like ProjectNotReady 503s) by suggesting commands that verify if previous commands worked, repeating the command again and if the fialures persist, checking the status page or reaching out on Discord.How has this been tested? (if applicable)
N/A