bug: project entering a state loop #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Sep 21, 2023
orhun
approved these changes
Sep 21, 2023
iulianbarbu
added a commit
to GugaGongadze/shuttle
that referenced
this pull request
Sep 27, 2023
Co-authored-by: Iulian Barbu <14218860+iulianbarbu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Projects sometimes seem to get stuck in a startup loop when the startup accidentally runs with a project stop command. That is because this
refreshfunction, maybe being called from the ambulance task, maybe from something else, would have incorrectly put a project that is starting up, directly after a restart, back into the restart state.How has this been tested? (if applicable)
By starting gateway locally and messing with the container state to first reproduce it and then to confirm the fix is working.