chore(docker): set up a local shared postgres for development #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Sep 25, 2023
docker-compose.dev.yml
Outdated
| @@ -30,6 +30,22 @@ services: | |||
| resource-recorder: | |||
| ports: | |||
| - 8007:8000 | |||
| depends_on: | |||
| - auth | |||
There was a problem hiding this comment.
Nit: The .dev.yml file will be combined with the docker-compose.yml into docker-compose.rendered.yml for local development, so we don't need to specify the auth dependency here. I see we did the same thing for logger in this file.
iulianbarbu
approved these changes
Sep 25, 2023
oddgrd
reviewed
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR updates Makefile/
docker-composefile for creating a local/shared Postgres database called "control DB" for development.I also realized we already have a shared Postgres at
/dev/tcp/postgres/5432which begs the question do we still need this control DB?How has this been tested? (if applicable)
N/a