feat: suggest project restart when trying to delete #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orhun
reviewed
Nov 4, 2023
| client.delete_project(self.ctx.project_name(), true).await.map_err(|err| { | ||
| if let Some(api_error) = err.downcast_ref::<ApiError>() { | ||
| // If the returned error string changes, this could break | ||
| if api_error.message.contains("not ready") { |
There was a problem hiding this comment.
Not sure if we should use plain string match or have a constant somewhere for the message and check that.
e.g.
const PROJECT_NOT_READY_MSG: &str = "project not ready. Try running `cargo shuttle project restart`.";It is something trivial but worth considering I think.
There was a problem hiding this comment.
I used a small string for matching, because if an entire string is used like that, a single change to the string will be breaking, like we saw in #1360. In this scenario, it wouldn't break functionality, just the extra hint, but still.
oddgrd
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Additional context when project is not ready on delete command.
How has this been tested? (if applicable)
See image above