Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump base64 to 0.21.5 #1403

Merged

Conversation

cassie-rust
Copy link
Contributor

Description of change

Bumps base64 version to 0.20.0, which contains breaking changes from 0.13.1

This PR only updates existing tests, which didn't compile with the upgrade.

I did not find any existing tests for url-unsafe characters, and I feel it's not my place to decide on the necessity of them -- I leave that to the maintainers to decide; there is a subtle difference in behavior, as explained here: marshallpierce/rust-base64#206 (comment)

Closes #1393

How has this been tested? (if applicable)

I ran cargo test -p shuttle-common before upgrade, and after. Both suites passed, which they shouldn't given the incompability. On trying to run the unit tests themselves, it failed, silently. Running the tests from vscode produces the following:

Executing task: cargo test --package shuttle-common --lib -- backends::auth::tests --nocapture 

    Finished test [unoptimized + debuginfo] target(s) in 0.22s
     Running unittests src/lib.rs (target/debug/deps/shuttle_common-28e6d65a277dfe89)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 9 filtered out; finished in 0.00s

I've yet to successfully even /run/ these tests, and I'm at my wit's end. However, cargo clippy will try and compile and blow up because of incompatibilities and so I used that as a guide. It compiles, but it has not been tested.

@orhun orhun changed the title improvement: bump base64 to 0.20.0 chore(deps): bump base64 to 0.20.0 Nov 19, 2023
Copy link
Contributor

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@oddgrd
Copy link
Contributor

oddgrd commented Nov 21, 2023

Thanks @cassie-rust, this looks great! I'm wondering, should we upgrade to the latest version (currently 0.21.5)?

You'll need some feature flags enabled to run the tests: cargo test -p shuttle-common --features backend,service,display (or --all-features). They pass 🥳

@cassie-rust
Copy link
Contributor Author

Sure, I can do that; it seems to mostly be namespace changes between 0.20 and 0.21

@oddgrd
Copy link
Contributor

oddgrd commented Nov 21, 2023

Cool!

@cassie-rust cassie-rust force-pushed the improvement-bump-base64-dependency branch from d3c269c to 8848fe7 Compare November 22, 2023 07:52
@cassie-rust cassie-rust changed the title chore(deps): bump base64 to 0.20.0 chore(deps): bump base64 to 0.21.5 Nov 22, 2023
@cassie-rust
Copy link
Contributor Author

Bumped to 0.21.5 instead.

Copy link
Member

@jonaro00 jonaro00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonaro00 jonaro00 merged commit 263fb0d into shuttle-hq:main Nov 22, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Bump base64 dependency
4 participants