chore(deps): bump base64 to 0.21.5 #1403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Bumps
base64
version to 0.20.0, which contains breaking changes from 0.13.1This PR only updates existing tests, which didn't compile with the upgrade.
I did not find any existing tests for url-unsafe characters, and I feel it's not my place to decide on the necessity of them -- I leave that to the maintainers to decide; there is a subtle difference in behavior, as explained here: marshallpierce/rust-base64#206 (comment)
Closes #1393
How has this been tested? (if applicable)
I ran
cargo test -p shuttle-common
before upgrade, and after. Both suites passed, which they shouldn't given the incompability. On trying to run the unit tests themselves, it failed, silently. Running the tests from vscode produces the following:I've yet to successfully even /run/ these tests, and I'm at my wit's end. However,
cargo clippy
will try and compile and blow up because of incompatibilities and so I used that as a guide. It compiles, but it has not been tested.