auth: comment healthcheck start_period & start_interval
#1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
force-pushed
the
fix/auth-deployment-healthcheck
branch
from
392534a
to
20baca5
Compare
oddgrd
approved these changes
Nov 22, 2023
oddgrd
reviewed
Nov 22, 2023
| @@ -58,8 +58,10 @@ services: | |||
| interval: 1m | |||
| timeout: 10s | |||
| retries: 5 | |||
| start_period: 10s | |||
There was a problem hiding this comment.
It looks like we should be able to use this, is it useful on its own: https://docs.docker.com/compose/compose-file/compose-versioning/#version-34?
There was a problem hiding this comment.
Nope, because the interval is set to 1 minute, so no health-check will be applied during that period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
CircleCI staging/prod deployment will fail because the
start_periodandstart_intervalconfigs forhealthcheckare not handled gracefully when deploying the stack. The deployment will fail due to using a Docker Engine version that does not support the configs.This PR comments on the configs explaining why, and when we'll upgrade, we can uncomment them.
How has this been tested? (if applicable)
Releasing on staging for #1402 .