Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: comment healthcheck start_period & start_interval #1414

Merged
merged 1 commit into from Nov 23, 2023
Merged

auth: comment healthcheck start_period & start_interval #1414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions docker-compose.yml
View file
Open in desktop
Expand Up @@ -58,8 +58,10 @@ services:
interval: 1m
timeout: 10s
retries: 5
start_period: 10s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should be able to use this, is it useful on its own: https://docs.docker.com/compose/compose-file/compose-versioning/#version-34?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, because the interval is set to 1 minute, so no health-check will be applied during that period.

start_interval: 2s
# These options are pending on an upgrade to Docker Engine version 25.0.
# Using them will result in error because they are not handled gracefully.
# start_period: 10s
# start_interval: 2s
builder:
image: "${CONTAINER_REGISTRY}/builder:${BUILDER_TAG}"
depends_on:
Expand Down