Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statics not built/collected for admin #33

Closed
jaywink opened this issue Jul 1, 2015 · 4 comments
Closed

Statics not built/collected for admin #33

jaywink opened this issue Jul 1, 2015 · 4 comments

Comments

@jaywink
Copy link
Contributor

jaywink commented Jul 1, 2015

Added Shoop current master to requirements (from git), installed and it did lots of nice build jobs as such. In my project I then did collectstatic, loaded up the shop and front page looks good. However, going to /sa shows admin statics were not collected. Verified in my static folder they are missing. Also they are not in /static/shoop_admin in the site packages, only images and fonts there. So more likely a build issue than collection issue.

selection_091

The build job did build them, the pip install ended with:

    *** (1/2) Building: ./shoop/notify
    Saving build result of ./shoop/notify
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/00/ea603f7ecf1406b9067f9318ae8118411eb0b9/static/notify/admin/script-editor-bundle.js
    *** (2/2) Building: ./shoop/admin
    Saving build result of ./shoop/admin
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/js/picotable.js
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/js/base.js
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/js/dashboard.js
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/js/media-browser.js
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/js/vendor.js
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/js/remarkable.js
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/css/media-browser.css
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/css/base.css
    Caching to: /home/jaywink/.cache/shoop/build_resources/prod/e4/3133f611bedb3b59e4abeb4678afd3c9128021/static/shoop_admin/css/dashboard.css
Successfully installed shoop
Cleaning up...

Something missing that pushes them to the static folder for collection?

shoop==1.0.0.post0.dev78-g8bb9e05
pip 1.5.6
Python 3.4.3
Ubuntu 15.04

Oh and btw, not sure if intended, but if I install from git with pip using the -e flag, the builds are not triggered at all.

@akx
Copy link
Contributor

akx commented Jul 1, 2015

This should be resolved in PR #32 (commit f258cb5).

@akx
Copy link
Contributor

akx commented Jul 2, 2015

Can you try this again with the current master (since #32 is now merged)? :)

@jaywink
Copy link
Contributor Author

jaywink commented Jul 2, 2015

Thanks, works like a charm! 🍪

Btw, while it was running this time there was no output, which looks clean but on my i3 laptop it took at least a minute which might be confusing for someone. But I guess cleaner output is better, just saying if that was not intended.

selection_083

@jaywink jaywink closed this as completed Jul 2, 2015
@suutari-ai
Copy link
Contributor

Can't do much about that, since it's pip that is hiding the output of the build process. If you do python setup.py instal directly (in venv to not pollute your global env) instead of through pip, you should get the output of the build step. Anyway, this should be no issue when we have published the Wheel, since it will contain the built resources and therefore installs instantaneously, and pip will use a wheel is one is available.

tulimaki pushed a commit to tulimaki/shuup that referenced this issue Jan 3, 2017
Core: add custom error pages for Shuup (EE-50)
maximlion pushed a commit to maximlion/shuup that referenced this issue Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants