Docker, Docker everywhere #32
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
PR or commit messages doesn't say much, but looks like we get somekind of docker support for Shoop. That sounds nice. |
Please add better explanation to this commit message to explain why the order has to be changed. There is some stuff in parenthesis that does not belong to title line, but rather you should have a paragraph or two explaining what used to happen and how this commit changes it. We used quite a lot of time to debug this and commit message is a good place to log the (relevant) things we found out while debugging it. |
It turns out that the `build_py` command actually also copies data files into the build directory. This naturally means we'll have to do the Node.js based builds before `build_py` is allowed to copy those artifacts further. Refs SHOOP-994
Much quicker `migrate` (since there's, well, no `migrate`) for Docker and testing purposes. Refs SHOOP-983
|
Fixed (to some degree), @suutari-ai |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -0,0 +1,11 @@ | |||
| FROM node:0.12.5 | |||
| RUN apt-get update && apt-get install -y --no-install-recommends python3-minimal python3-virtualenv python3-pip python3-dev python3-pil | |||
| RUN python3 -m virtualenv -p /usr/bin/python3 --system-site-packages /var/www/shoop/venv | |||
There was a problem hiding this comment.
Why system-site-packages?
Also, why not use "python3 -m venv" rather than "virtualenv" ?
There was a problem hiding this comment.
Why system-site-packages?
python3-pil
There was a problem hiding this comment.
OK then. I usually let PIL compile itself, but maybe installing it from deb packages is better idea for the Docker image.
There was a problem hiding this comment.
Also, venv doesn't seem to work:
Command '['/var/www/shoop/venv/bin/python3', '-Im', 'ensurepip', '--upgrade', '--default-pip']' returned non-zero exit status 1
and I don't really have the inclination to figure out why when virtualenv does the trick :)
There was a problem hiding this comment.
Let's use virtualenv then. Dunno what's the base image of node:0.12.5, but if it's Ubuntu, then probably the reason is this bug: https://bugs.launchpad.net/ubuntu/+source/python3.4/+bug/1290847
|
@akx, your commit message:
Exactly what I meant. Thanks! 👍 |
|
Refer to this link for build results (access rights to CI server needed): |
Yay, it docks a demo shop! Refs SHOOP-983
|
Refer to this link for build results (access rights to CI server needed): |
|
Good work, @akx. Thanks! |
Admin: Update wizard address form (CLOUD-65)
This PR adds a basic Dockerfile that can be used to boot up an "evaluation" instance of Shoop.