Notify: Show more Order related variables in editor #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2283 +/- ##
==========================================
- Coverage 88.15% 88.14% -0.01%
==========================================
Files 840 840
Lines 37455 37457 +2
Branches 4920 4920
==========================================
Hits 33017 33017
- Misses 3318 3319 +1
- Partials 1120 1121 +1
Continue to review full report at Codecov.
|
Add a new `attributes` attribute to `shuup.notify.base.Variable` for showing examples of which attributes can be accessed in the script templates. Refs IP-7
ruohola
changed the title
tulimaki
approved these changes
Oct 13, 2020
tulimaki
added
the
hactoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
attributesattribute toshuup.notify.base.Variableforshowing examples of which attributes can be accessed in the script templates.
Refs IP-7
The new
attributeslook like this in the script editor:(Note that the the javascript for the variable links didn't work even before this PR, but once it gets fixed the attributes were made so that they should work just fine with that)