LPS-81983 Portlet 3.0: Deprecate usage of portal-kernel StringBundler in favor of petra StringBundler for OutputData and OutputTag #6285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guageId and _getDefaultLanguageId function
… interface and base classes
…e constructors of the base classes
… - uses defaults from ManagementToolbarDefaults
… internal package as the DisplayContext
…arting slim runtime, rename to ext-spring-slim.xml and modify the properties accordingly.
…ses services that might not ready to be used.
This reverts commit 9b99af0.
… in favor of petra StringBundler for OutputData and OutputTag
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test |
The pull request tester is still running.Please wait until you get the final report before running 'ci:retest'. See this link to check on the status of your test: However, the pull request was closed.The pull request was closed because the following critical batches had failed:
For information as to why we automatically close out certain pull requests see this article. *This pull will no longer automatically close if this comment is available. If you believe this is a mistake please reopen this pull by entering the following command as a comment. ci:reopen Critical Failure Details:test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2105-jdk8Job Results:8989 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/modules-integration-hypersonic20-jdk8Job Results:8990 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/modules-integration-mariadb100-jdk8Job Results:8989 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8Job Results:8989 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle121-jdk8Job Results:8989 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql94-jdk8Job Results:8989 Tests Passed.
test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase160-jdk8Job Results:8989 Tests Passed. |
liferay-continuous-integration
added
ci:test - failure
and removed
ci:test - pending
labels
|
@shuyangzhou The "Failures unique to this pull" all state "No Group exists with the primary key 0" in tests related to staging. I can't see how that is related to a change from portal-kernel StringBundler to petra StringBundler. Please review when you get an opportunity. This is the new #1 since it is a blocker. Thank you, Neil |
|
ci:reopen |
|
@shuyangzhou Note that this change can cause JSPs that use
If you approve this PR then I will make sure that gets added to the "Breaking Changes" document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.