Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aop #7014

Closed
wants to merge 41 commits into from
Closed

Aop #7014

wants to merge 41 commits into from

Conversation

shuyangzhou
Copy link
Owner

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@shuyangzhou
Copy link
Owner Author

ci:test

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 184 out of 192 jobs passed in 2 hours 9 minutes 23 seconds 306 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f2c7cdaca195540799150306bff1d182600815a8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 70b3a7af2ba3a9b3444b7ab2063d5069ac233251

184 out of 192 jobs PASSED
184 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #228734
           [java] java.lang.Exception: Found 1 formatting issues:
           [java] 1: ./portal-impl/src/com/liferay/portal/spring/aop/ServiceBeanAopProxy.java expected:<...nel.util.ProxyUtil;
           [java] [import com.liferay.portal.transaction.TransactionsUtil;
           [java] 
           [java] import java.lang.reflect.InvocationHandler;
           [java] import java.lang.reflect.Method;
           [java] ]
           [java] import org.aopallia...> but was:<...nel.util.ProxyUtil;
           [java] [
           [java] import java.lang.reflect.InvocationHandler;
           [java] import java.lang.reflect.Method;
           [java] 
           [java] import com.liferay.portal.transaction.TransactionsUtil;]
           [java] import org.aopallia...>
           [java] 
           [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:412)
           [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:239)
           [echo] The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:671: Java returned: 1
            [get] Getting: http://test-1-9/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/228734//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20181108021515923.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20181108021515923.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1783080567.properties
      

      merge-test-results:
      [mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
      [junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null2131114591
      [junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
      [junitreport] Transform time: 227ms
      [junitreport] Deleting: /tmp/null2131114591
      [echo] A report with all the test results can be found at test-results/html/index.html.
      [mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results
      [echo]
      [echo] Ant GC log:
      [echo]
      [echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)
      [echo] Memory: 4k page, physical 16777216k(4176380k free), swap 2097152k(1437948k free)

  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/58
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #246227
           [exec] 	at org.gradle.api.internal.tasks.compile.JdkJavaCompiler.execute(JdkJavaCompiler.java:33)
      [exec] at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.delegateAndHandleErrors(NormalizingJavaCompiler.java:99)
      [exec] at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:52)
      [exec] at org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:37)
      [exec] at org.gradle.api.internal.tasks.compile.CleaningJavaCompilerSupport.execute(CleaningJavaCompilerSupport.java:35)
      [exec] at org.gradle.api.internal.tasks.compile.CleaningJavaCompilerSupport.execute(CleaningJavaCompilerSupport.java:25)
      [exec] at org.gradle.api.tasks.compile.JavaCompile.performCompilation(JavaCompile.java:244)
      [exec] at org.gradle.api.tasks.compile.JavaCompile.compile(JavaCompile.java:229)
      [exec] at org.gradle.api.tasks.compile.JavaCompile.compile(JavaCompile.java:151)
      [exec] at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73)
      [exec] at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$IncrementalTaskAction.doExecute(DefaultTaskClassInfoStore.java:163)
      [exec] at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
      [exec] at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)
      [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.execute(ExecuteActionsTaskExecuter.java:115)
      [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.execute(ExecuteActionsTaskExecuter.java:109)
      [exec] at org.gradle.internal.Transformers$4.transform(Transformers.java:169)
      [exec] at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)
      [exec] at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)
      [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:109)
      [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:90)
      [exec] ... 62 more
      [exec]
  3. test-portal-acceptance-pullrequest-batch(master)/integration-oracle122-jdk8
    Job Results:

    3304 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #228731
      1. CounterLocalServiceTest.testConcurrentIncrement
        java.util.concurrent.ExecutionException: com.liferay.portal.kernel.process.ProcessException: java.lang.RuntimeException: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'liferayDataSourceImpl' defined in class path resource [META-INF/infrastructure-spring.xml]: Invocation of init method failed; nested exception is java.lang.RuntimeException: No dialect found
        at java.util.concurrent.FutureTask.report(FutureTask.java:122)
        at java.util.concurrent.FutureTask.get(FutureTask.java:192)
        at com.liferay.counter.service.CounterLocalServiceTest.testConcurrentIncrement(CounterLocalServiceTest.java:168)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61)
        at com.liferay.portal.kernel.test.rule.BaseTestRule$1.evaluate(BaseTestRule.java:61...

@shuyangzhou
Copy link
Owner Author

ci:test

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 188 out of 192 jobs passed in 3 hours 5 minutes 6 seconds 290 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f2c7cdaca195540799150306bff1d182600815a8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 70b3a7af2ba3a9b3444b7ab2063d5069ac233251

188 out of 192 jobs PASSED
188 Successful Jobs:
For more details click here.

Failures unique to this pull:

For upstream results, click here.

@@ -62,8 +63,7 @@ protected Object wrapIfNecessary(

ProxyFactory proxyFactory = new ProxyFactory();

evaluateProxyInterfaces(beanClass, proxyFactory);

proxyFactory.setInterfaces(ReflectionUtil.getInterfaces(bean));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReflectionUtil.getInterfaces() doesn't have the same result as spring's lookup. Spring also includes extended interfaces.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 151 out of 192 jobs passed in 3 hours 24 minutes 9 seconds 304 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d35f4a7c2b5a7bffd79695ed1ef44148cf053d80

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 530c44c1a96eaa641f2bcca8acc7c7f2854b7c1d

151 out of 192 jobs PASSED

41 Failed Jobs:

151 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/source-format-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #239259
           [java] java.lang.Exception: Found 1 formatting issues:
           [java] 1: ./portal-kernel/test/unit/com/liferay/portal/kernel/servlet/filters/invoker/FilterMappingTest.java expected:<...ava.util.ArrayList;
           [java] []
           [java] import javax.servle...> but was:<...ava.util.ArrayList;
           [java] [import java.util.List;
           [java] ]
           [java] import javax.servle...>
           [java] 
           [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:412)
           [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:239)
           [echo] The following error occurred while executing this line:
           [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:671: Java returned: 1
            [get] Getting: http://test-1-7/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/239259//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20181108203024250.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20181108203024250.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1586022956.properties
      

      merge-test-results:
      [mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
      [junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null249673094
      [junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
      [junitreport] Transform time: 289ms
      [junitreport] Deleting: /tmp/null249673094
      [echo] A report with all the test results can be found at test-results/html/index.html.
      [mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results
      [copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results
      [echo]
      [echo] Ant GC log:
      [echo]
      [echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)
      [echo] Memory: 4k page, physical 16777216k(2759528k free), swap 2097152k(1447472k free)

  2. ...

@shuyangzhou
Copy link
Owner Author

ci:test

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test - 153 out of 192 jobs passed in 2 hours 57 minutes 50 seconds 127 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d35f4a7c2b5a7bffd79695ed1ef44148cf053d80

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 530c44c1a96eaa641f2bcca8acc7c7f2854b7c1d

153 out of 192 jobs PASSED

39 Failed Jobs:

153 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/bundle-blacklist-restart-jdk8
    Job Results:

    5 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #197159
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'com.liferay.portal.spring.aop.ServiceBeanAutoProxyCreator#0' defined in URL [bundleentry://263.fwk594207037/META-INF/spring/kaleo-spring.xml]: Cannot resolve reference to bean 'aopProxyFactory' while setting bean property 'aopProxyFactory'; nested exception is org.springframework.beans.factory.CannotLoadBeanClassException: Cannot find class [com.liferay.portal.spring.aop.AopProxyFactoryImpl] for bean with name 'aopProxyFactory' defined in URL [bundleentry://263.fwk594207037/META-INF/spring/kaleo-spring.xml]; nested exception is java.lang.ClassNotFoundException: com.liferay.portal.spring.aop.AopProxyFactoryImpl
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:174)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:100)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:90)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:88)
        
  2. test-portal-acceptance-pullrequest-batch(master)/empty-temp-dir-jdk8
    Job Results:

    3 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #115706
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'com.liferay.portal.spring.aop.ServiceBeanAutoProxyCreator#0' defined in URL [bundleentry://262.fwk1475908890/META-INF/spring/kaleo-spring.xml]: Cannot resolve reference to bean 'aopProxyFactory' while setting bean property 'aopProxyFactory'; nested exception is org.springframework.beans.factory.CannotLoadBeanClassException: Cannot find class [com.liferay.portal.spring.aop.AopProxyFactoryImpl] for bean with name 'aopProxyFactory' defined in URL [bundleentry://262.fwk1475908890/META-INF/spring/kaleo-spring.xml]; nested exception is java.lang.ClassNotFoundException: com.liferay.portal.spring.aop.AopProxyFactoryImpl
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:174)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:100)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:90)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:88)
        
  3. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-jboss71-mysql57-jdk8/0
    Job Results:

    3 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #252612
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Invocation of 'start' failed. 
        java.lang.Exception: Unable to start com.liferay.portal.workflow.kaleo.runtime.impl
        	at com.liferay.portal.spring.extender.internal.context.ModuleApplicationContextRegistrator.start(ModuleApplicationContextRegistrator.java:94)
        	at org.apache.felix.dm.InvocationUtil.invokeMethod(InvocationUtil.java:111)
        	at org.apache.felix.dm.InvocationUtil.invokeCallbackMethod(InvocationUtil.java:66)
        	at org.apache.felix.dm.impl.ComponentImpl.invokeCallbackMethod(ComponentImpl.java:769)
        	at org.apache.felix.dm.impl.ComponentImpl.invoke(ComponentImpl.java:760)
        	at org.apache.felix.dm.impl.ComponentImpl.bindService(ComponentImpl.java:705)
        	at org.apache.felix.dm.impl.ComponentImpl.access$400(ComponentImpl.java:54)
        	at org.apache.felix.dm.impl.ComponentImpl$7.run(ComponentImpl.java:202)
        	at org.apache.felix.dm.impl.SerialExecutor.runTask(SerialExecutor.java:137)
        	at org.apache.felix.dm.impl.SerialExecutor.runTasks(SerialExecutor.java:119)
        	at org.apache.felix.dm.impl.SerialExecutor.execute(SerialExecutor.java:85)
        	at org.apache.felix.dm.impl.ComponentImpl.calculateStateChanges(ComponentImpl.java:252)
        	at org.apache.felix.dm.impl.ComponentImpl.dependencyAvailable(ComponentImpl.java:379)
        	at org.apache.felix.dm.impl.dependencies.ServiceDependencyImpl.doAddedService(ServiceDependencyImpl.java:849)
        	at org.apache.felix.dm.impl.dependencies.ServiceDependencyImpl.access$200(ServiceDependencyImpl.java:60)
        	at org.apache.felix.dm....
  4. test-portal-acceptance-pullrequest-batch(master)/functional-smoke-tcserver40-mysql57-jdk8/0
    Job Results:

    3 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #267658
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'com.liferay.portal.spring.aop.ServiceBeanAutoProxyCreator#0' defined in URL [bundleentry://262.fwk838274583/META-INF/spring/kaleo-spring.xml]: Cannot resolve reference to bean 'aopProxyFactory' while setting bean property 'aopProxyFactory'; nested exception is org.springframework.beans.factory.CannotLoadBeanClassException: Cannot find class [com.liferay.portal.spring.aop.AopProxyFactoryImpl] for bean with name 'aopProxyFactory' defined in URL [bundleentry://262.fwk838274583/META-INF/spring/kaleo-spring.xml]; nested exception is java.lang.ClassNotFoundException: com.liferay.portal.spring.aop.AopProxyFactoryImpl
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:174)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:100)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:90)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:88)
        
  5. ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants