Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix]LPS-123728 #9751

Closed
wants to merge 386 commits into from
Closed

[Bug Fix]LPS-123728 #9751

wants to merge 386 commits into from

Conversation

tinatian
Copy link

No description provided.

Javier de Arcos and others added 30 commits January 26, 2021 09:33
@brianchandotcom
LPS-125672 Add examples to demonstrate the usage of scoped external r…
e76f812 
…eference code
@brianchandotcom
LPS-125672 follow existing patterns
0753392
@brianchandotcom
LPS-125672 Build Service
5786a4c
@brianchandotcom
LPS-125672 Source Formatter
d1ad581
@brianchandotcom
LPS-125672 Manual SF
b9099f1
@brianchandotcom
LPS-125672 prep next
363badd
@brianchandotcom
LPS-105380 LPS-121804 prep next
b2de68d
@brianchandotcom
LPS-105380 LPS-121804 LPS-125672 prep next
b79d738
@boton @brianchandotcom
LPS-126693 Check if maxFileSize is unlimited 0
1b2072b
@brianchandotcom
LPS-126692 Partially revert LPS-124180. Validation was too strict for…
5994401 
… other use cases. The parent page is published to live if it doesn't exist yet, therefore the validation shouldn't fail anyways.
@victorg1991 @brianchandotcom
LPS-126763 Disable d&d when the alloy editor is active
6872d75
@Hanlf @brianchandotcom
LPS-124469 Update macro to assert the warning message
ab8d54b
@sandrodw3 @brianchandotcom
LPS-126761 Avoid dispatching unnecessary action when clicking current…
b83378c 
… viewport selector
@hhuijser @brianchandotcom
LPS-115709 Rename jsp to match mvc.command.name
cdbf432
@brianchandotcom
LPS-126628 Add locator for grouped selected value any
f234e10
@brianchandotcom
LPS-126628 Add case to view available content templates in Content Di…
dccf576 
…splay
@brianchandotcom
LPS-126628 Increase priority to 3
0971634
@brianchandotcom
LPS-126631 Add locator for Grid option
0b0d48d
@brianchandotcom
LPS-126631 Modify macro to set up grid option
c57d729
@brianchandotcom
LPS-126631 Modify macro to make it reusable
2a5b560
@brianchandotcom
LPS-126631 Add locator for web content content any
7106355
@brianchandotcom
LPS-126631 Modify macro to make option values special
bb2c1b4
@brianchandotcom
LPS-126631 Add case to view web content with all fields in Content Di…
9ea3055 
…splay
@brianchandotcom
LPS-126631 Increase priority to 3
fae8592
@brianchandotcom
LPS-126632 Modify tag
6ea54ca
@brianchandotcom
LPS-126632 Add a new web content template file
82d60a4
@brianchandotcom
LPS-126632 Add case to assert select web content template from script…
24ebc67 
… file in Content Display
@brianchandotcom
LPS-126633 Add case to assert select custom web content template in C…
012bb27 
…ontent Display with staging
@brianchandotcom
LPS-126634 Add case to assert select web content template from Global…
074d1e3 
… site in Content Display
@brianchandotcom
LPS-126628 Rename case
ebaef60
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@tinatian
Copy link
Author

ci:test:relevant

@tinatian
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fa6ecdb8ad0e059654aff51e1216a57a8ddd272a

Sender Branch:

Branch Name: LPS-123728-4
Branch GIT ID: 9c7dbc0161f481fc9a953af9d8de59e8fd555f51

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#5240
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:shuyangzhou#9751
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - tinatian > shuyangzhou - PR#9751 - 2021-01-28[10:30:50]
Spira Jenkins Build:publish-spira-report#14898

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 2 hours 16 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9a9ff64e9530a2250ef56e6312ce54a686e4e727

Upstream Comparison:

Branch GIT ID: 9a9ff64e9530a2250ef56e6312ce54a686e4e727
Jenkins Build URL: Acceptance Upstream DXP (master) #1498

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 9a9ff64:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
    Job Results:

    58 Tests Passed.
    11 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #326655
      1. VelocityTemplateTest.testPrepare
        java.lang.NoClassDefFoundError: com/liferay/portal/configuration/persistence/ConfigurationOverridePropertiesUtil
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil._overrideMap(ConfigurableUtil.java:245)
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil.createConfigurable(ConfigurableUtil.java:60)
	at com.liferay.portal.template.velocity.internal.VelocityTemplateTest.setUp(VelocityTemplateTest.java:91)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChild...
      2. VelocityTemplateTest.testProcessTemplate7
        java.lang.NoClassDefFoundError: com/liferay/portal/configuration/persistence/ConfigurationOverridePropertiesUtil
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil._overrideMap(ConfigurableUtil.java:245)
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil.createConfigurable(ConfigurableUtil.java:60)
	at com.liferay.portal.template.velocity.internal.VelocityTemplateTest.setUp(VelocityTemplateTest.java:91)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChild...
      3. VelocityTemplateTest.testProcessTemplate8
        java.lang.NoClassDefFoundError: com/liferay/portal/configuration/persistence/ConfigurationOverridePropertiesUtil
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil._overrideMap(ConfigurableUtil.java:245)
	at com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil.createConfigurable(ConfigurableUtil.java:60)
	at com.liferay.portal.template.velocity.internal.VelocityTemplateTest.setUp(VelocityTemplateTest.java:91)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChild...
      4. ...

@shuyangzhou
Copy link
Owner

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#98205

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#8973
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:shuyangzhou#9751
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - tinatian > shuyangzhou - PR#9751 - 2021-01-28[10:30:50]
Spira Jenkins Build:publish-spira-report#10572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.