-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-131269 #9994
LPS-131269 #9994
Conversation
These imports don't make sense because frontend-js-web is bundler-excluding everything since long ago, so there's no way anybody can consume/have consumed them.
Since we don't need to have two files any more.
We are now using the standard preset always (it is injected from npm-scripts) so there's no point in setting the preset because it's a NO-OP.
We used `preset: false` as a way to disable the bundler but this: 1. Ran the bundler for doing nothing 2. Looked a bit hacky Now that we have `bundling: false` (because we added it for webpack federation), use it instead.
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test:sf |
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-131269 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#5727 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:shuyangzhou#9994 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - marianoalvarosaiz > shuyangzhou - PR#9994 - 2021-04-30[10:11:47] Testray Importer:publish-testray-report#540 |
✔️ ci:test:stable - 9 out of 9 jobs passed✔️ ci:test:relevant - 20 out of 21 jobs passed in 1 hour 57 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 318146d8babd408ff5f16b93b0e04428cbf3241f ci:test:stable - 9 out of 9 jobs PASSED9 Successful Jobs:
ci:test:relevant - 19 out of 21 jobs PASSED2 Failed Jobs:19 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at 318146d:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#7971 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:shuyangzhou#9994 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - marianoalvarosaiz > shuyangzhou - PR#9994 - 2021-04-30[10:11:52] Testray Importer:publish-testray-report#541 |
See #9998 |
No description provided.