Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about the time series used in the plot #60

Closed
Shyentist opened this issue Jul 31, 2021 · 1 comment
Closed

Add info about the time series used in the plot #60

Shyentist opened this issue Jul 31, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@Shyentist
Copy link
Owner

Having that information somewhere in the plot reduces ambiguity after the png file is downloaded. I have some options in mind:

  • A title like "GFW data from [start-date] to [end-date]"
  • A caption under the plot saying "GFW data from [table name] where [SQL query filters as shown in the Query tab]. This would be the less ambiguous way, but also less user-friendly, since it would look something like "GFW data from global-fishing-watch.gfw_public_data.fishing_effort_byvessel_v2 where date >= '2012-01-01' AND date < '2012-01-02' AND cell_ll_lat >= 40 AND cell_ll_lat < 46 AND cell_ll_lon >= 10 AND cell_ll_lon < 16"

I will think about it. If anyone reads this issue, and has a better solution, please comment below.

@Shyentist Shyentist added the enhancement New feature or request label Jul 31, 2021
@Shyentist Shyentist added this to the Second JOSS Review milestone Jul 31, 2021
@Shyentist
Copy link
Owner Author

The more I think about this, the more it seems like a bad idea. A mere date range is definitely not the title anyone would go for, while also being ambiguous, given that one could show data from (for instance) the 5th to the 25th of January (with according title), even though they queried 1st to 31st of January, simply because there is no data for the other days. The issue could be solved by using the SQL query, but users can upload their CSV or GPKG, which lose the SQL query, and would give the ambiguous result.

In addition, the fact that any general name I might use is definitely worse than the result the user can achieve with something as simple as Paint, makes the possible result of this implementation sub-optimal to begin with.

I will leave this open for another week (until August 21st). If further thinking does not change my mind, I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant