Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuspendingTabCompleter missing default support #76

Closed
Yomanz opened this issue Sep 9, 2022 · 2 comments
Closed

SuspendingTabCompleter missing default support #76

Yomanz opened this issue Sep 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@Yomanz
Copy link

Yomanz commented Sep 9, 2022

The SuspendingTabCompleter doesn't have the same level of support as the regular TabCompleter provided in Paper.

You can return null to the TabCompleter to allow it to fall back to the default command executor but the signature for SuspendingTabCompleter.onTabComplete is:

suspend fun onTabComplete(
       sender: CommandSender,
       command: Command,
       alias: String,
       args: Array<out String>
   ): List<String>

compared to TabCompleter.onTabComplete

@Nullable
public List<String> onTabComplete(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label, @NotNull String[] args);
@Shynixn
Copy link
Owner

Shynixn commented Sep 10, 2022

That's true, thanks for reporting this.
Hm... the only problem is that simply changing this is a breaking change for existing plugins using this feature. I may even need to do a major version change.

@Shynixn Shynixn added the bug Something isn't working label Sep 10, 2022
Shynixn pushed a commit that referenced this issue Sep 11, 2022
@Shynixn Shynixn closed this as completed Sep 11, 2022
@Yomanz
Copy link
Author

Yomanz commented Sep 11, 2022

Thanks for sorting this so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants