Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGSFragariaPreferences role? #30

Closed
balthisar opened this issue Feb 22, 2015 · 2 comments
Closed

MGSFragariaPreferences role? #30

balthisar opened this issue Feb 22, 2015 · 2 comments

Comments

@balthisar
Copy link

MGSFragariaPreferences is currently instituted as a singleton, but the only use of it in the code is in the Simple demo application, where it's only used to eventually resolve back to the shared NSUserDefaultsController.

It also provides ready-made instances of the two view controllers, but the demo app is instantiating its own controllers, so these aren't really necessary, either, unless we want them to remain for other applications to use.

I'll keep it all in and add lazy instantiation for the controllers, but I'd like to rip this out entirely, as I don't see a need for it.

@shysaur
Copy link
Owner

shysaur commented Feb 22, 2015

First we have to move out its initializeValues method and the preference constants to the new preferences controller. Then we can delete it.

@shysaur shysaur closed this as completed in 80f8e81 Mar 3, 2015
@shysaur
Copy link
Owner

shysaur commented Mar 3, 2015

Now the files for MGSFragariaPreferences are just the declarations for the preference keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants